This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Fix tests that broke due to changes on Atom Beta#980
Merged
smashwilson merged 2 commits intomasterfrom Jun 27, 2017
Merged
Conversation
Context: the `TextBuffer.save` method became async in atom/atom#14435; instead of doing a synchronous write, it initiates an asynchronous write and return a promise when the write completes.
This method now returns a promise per: atom/atom@dc32018#diff-1a7d1dda35d8e7ed3ad35b9a9fd2f134R605 Relies on atom/atom#14884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple APIs changed in Atom core.
TextBuffer.prototype.saveis now asynchronous, as well asPane.prototype.destroyItemDepends on atom/atom#14884